[Webkit-unassigned] [Bug 216123] [GTK][WPE] WEBKIT_PLUGIN_ERROR_WILL_HANDLE_LOAD returned when plugins are disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216123

--- Comment #9 from Michael Catanzaro <mcatanzaro at gnome.org> ---
(In reply to Carlos Garcia Campos from comment #8)
> I meant adding a new error with the same code, but different domain, that
> needs to be handled by ephy. Ephy returns early if error domain is not
> network or policy, then it handles errors individually. If we add the new
> error to network or policy and ephy keeps current code just adding the new
> error it should just work.

It's not enough. I tested this with and without the Ephy patch and it was broken with WebKit trunk either way. (But 2.29.92 is fine, without the Ephy patch.)

> Because the patch is wrong, you are using WEBKIT_POLICY_ERROR domains for
> the WEBKIT_PLUGIN_ERROR_WILL_HANDLE_LOAD error.

Ah, oops. :P That explains it. So with that portion of r265753 reverted *properly*, then it works again. (Well, it "works" ignoring bug #183259.) So we just need to remember to change that as well if we change the error type.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200909/578ee153/attachment-0001.htm>