[Webkit-unassigned] [Bug 122952] [GTK][WPE] Support NTLM authentication

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122952

--- Comment #23 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #22)
> I tried:
> 
> diff --git a/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
> b/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
> index 498d1ac57277..9f8b71ac1a93 100644
> --- a/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
> +++ b/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
> @@ -132,6 +132,7 @@ SoupNetworkSession::SoupNetworkSession(PAL::SessionID
> sessionID)
>  #if SOUP_CHECK_VERSION(2, 67, 90)
>          SOUP_SESSION_ADD_FEATURE_BY_TYPE,
> SOUP_TYPE_WEBSOCKET_EXTENSION_MANAGER,
>  #endif
> +        SOUP_SESSION_ADD_FEATURE_BY_TYPE, SOUP_TYPE_AUTH_NTLM,
>          nullptr);
>  
>      if (!initialAcceptLanguages().isNull())
> 
> Since if we don't need API to enable/disable NTLM, all of the complexity of
> Carlos's original patch goes away. Unfortunately, the test page fails. In
> Firefox, I see a username/password prompt. In Epiphany, with this change, I
> see the text: "You are not authorized to see this page." Without this
> change, I just see a blank page. So looks like it needs a lot more
> investigation to get working.

It works for me with MiniBrowser. I don't know what have changed (if any), but this test site uses NTLM in WWW-Authenticate header, and that's only handled by SoupAuthNTLM, so the feature needs to be added.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200909/d2c15861/attachment.htm>