[Webkit-unassigned] [Bug 210525] CSS :visited color taken on non-visited link when using CSS variables

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=210525

--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 408059
  --> https://bugs.webkit.org/attachment.cgi?id=408059
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408059&action=review

> Source/WebCore/style/StyleBuilder.cpp:43
>  #include "StylePropertyShorthand.h"
>  
> +#include <wtf/SetForScope.h>

WebKit coding style does not leave a space between these making it two paragraphs. But fine to land like this for now.

> Source/WebCore/style/StyleBuilder.cpp:220
> +            SetForScope<SelectorChecker::LinkMatchMask> scopedLinkMatchMutation(m_state.m_linkMatch, index);

Oh, looks like there is a better way to write it:

    auto scopedLinkMatchMutation = SetForScope(m_state.m_linkMatch, index);

That way we don’t have to write out the type. But fine to land like this for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200905/7f50cec2/attachment.htm>