[Webkit-unassigned] [Bug 216172] [JSC] Use symbols as identifiers for class fields computed names storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216172

Caio Lima <ticaiolima at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ticaiolima at gmail.com

--- Comment #2 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 407975
  --> https://bugs.webkit.org/attachment.cgi?id=407975
Use symbols as identifiers

View in context: https://bugs.webkit.org/attachment.cgi?id=407975&action=review

> Source/JavaScriptCore/parser/Parser.cpp:2851
> +    Symbol* symbol = Symbol::create(vm, vm.symbolRegistry().symbolForKey(symbolName));

I think we'd like to use PrivateSymbols here instead. Also, I think it is necessary to use a separate SymbolRegistry for this internal usage, since we can have `Symbol.for("0")` from use code and I don't think it's safe to use something that can be retrieved by arbritrary code. Finally, I don't think we actually need to create a Symbol, since we are only interested into uid and `vm.symbolRegistry().symbolForKey(symbolName)` is already giving us that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20200904/0c69298b/attachment.htm>