[Webkit-unassigned] [Bug 218401] [GPU Process] Flush canvas displayList from doAfterUpdateRendering

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218401

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #412791|review?                     |review-
              Flags|                            |

--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 412791
  --> https://bugs.webkit.org/attachment.cgi?id=412791
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412791&action=review

> Source/WebCore/ChangeLog:8
> +
> +        No new tests (OOPS!).

This needs some explanation for the change. Remove the "No new tests" line.

> Source/WebCore/html/HTMLCanvasElement.cpp:373
> +    if (m_context)
> +        addObserver(document());

I don't think you should do this unconditionally. You should only do this when GPU Process is active. In fact, you should only do this when GPU Process is active, and drawing has occurred since the last flush.

> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:310
> +    bool needsPreparationForDisplay() const final { return true; }

This can't be unconditional. You should only return true when using the GPU backend. Ideally it would only return true if there is new drawing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201030/ffa39415/attachment-0001.htm>