[Webkit-unassigned] [Bug 218361] JS Promises in detached iframes do not settle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218361

--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
index c9e3be11872a..6f4ffa18644b 100644
--- a/Source/WebCore/dom/Document.cpp
+++ b/Source/WebCore/dom/Document.cpp
@@ -2711,8 +2711,8 @@ void Document::resumeActiveDOMObjects(ReasonForSuspension why)

 void Document::stopActiveDOMObjects()
 {
-    if (m_documentTaskGroup)
-        m_documentTaskGroup->stopAndDiscardAllTasks();
+    /*if (m_documentTaskGroup)
+        m_documentTaskGroup->stopAndDiscardAllTasks();*/
     ScriptExecutionContext::stopActiveDOMObjects();
     platformSuspendOrStopActiveDOMObjects();
 }
diff --git a/Source/WebCore/dom/Microtasks.cpp b/Source/WebCore/dom/Microtasks.cpp
index 2e4aa4b56c10..73cb09642adf 100644
--- a/Source/WebCore/dom/Microtasks.cpp
+++ b/Source/WebCore/dom/Microtasks.cpp
@@ -56,7 +56,7 @@ void MicrotaskQueue::performMicrotaskCheckpoint()
         Vector<std::unique_ptr<EventLoopTask>> queue = WTFMove(m_microtaskQueue);
         for (auto& task : queue) {
             auto* group = task->group();
-            if (!group || group->isStoppedPermanently())
+            if (!group/* || group->isStoppedPermanently()*/)
                 continue;
             if (group->isSuspended())
                 toKeep.append(WTFMove(task));

Had to do both these changes to make WebAudio tests pass (Bug 218363).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201029/b03e83e7/attachment-0001.htm>