[Webkit-unassigned] [Bug 218298] Make WebCore::ContainerNode::ChildChangeType enum class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218298

--- Comment #5 from Tetsuharu Ohzeki [UTC+9] <tetsuharu.ohzeki at gmail.com> ---
(In reply to Darin Adler from comment #4)
> (In reply to Tetsuharu Ohzeki from comment #3)
> > (In reply to Darin Adler from comment #2)
> > > Maybe this enumeration should be a in the ChildChange structure, with the
> > > name "Type" instead of next to the ChildChange structure with the name
> > > ChildChangeType.
> > 
> > In that case, should we make it enum class or keep it as enum?
> 
> I’m conflicted about that.


I'm trying to move ChildChangeType to ChildChange and keep it enum class. it would be a bit redundant like `ChildChange::Type::ElementInserted`.

I seem `ChildChange::ElementInserted` is concise at here and we achive to push ChildChangeType into some scope. So I will change to this pattern in the next patch.


And then, I also feel that we can move ChildChangeSource to ChildChange with keeping it as enum class.

Darin, how do you think about these?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201028/a886cd36/attachment.htm>