[Webkit-unassigned] [Bug 218298] Make WebCore::ContainerNode::ChildChangeType enum class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218298

--- Comment #3 from Tetsuharu Ohzeki <tetsuharu.ohzeki at gmail.com> ---
(In reply to Darin Adler from comment #2)
> Not sure this is an improvement. I understand that we like the idea of using
> enum class everywhere, but this makes all the code wordier and it’s not
> *obvious* to me that it’s better.

Ah, I see.


> Maybe this enumeration should be a in the ChildChange structure, with the
> name "Type" instead of next to the ChildChange structure with the name
> ChildChangeType.

In that case, should we make it enum class or keep it as enum?




> > Source/WebCore/dom/ContainerNode.h:77
> >      enum class ChildChangeSource { Parser, API };
> 
> Should probably put a base type of bool here?

I worried that but I did not touch it.
I'll change it in the next patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201028/f9d892b2/attachment-0001.htm>