[Webkit-unassigned] [Bug 216172] [JSC] Use symbols as identifiers for class fields computed names storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216172

Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #412410|0                           |1
        is obsolete|                            |
 Attachment #412410|review?, commit-queue?      |
              Flags|                            |
 Attachment #412513|                            |review?, commit-queue?
              Flags|                            |

--- Comment #21 from Xan Lopez <xan.lopez at gmail.com> ---
Created attachment 412513

  --> https://bugs.webkit.org/attachment.cgi?id=412513&action=review

Use symbols as identifiers, v8

v8,
Hrm, what you suggest does not seem to work (new failures introduced); a bit odd, since generator.shouldSetFunctionName() seems to be read-only.
I have rearranged the code a bit so that the boolean is used in both places and we keep a single call to the function. Seems a bit neater to me, let me know if that's fine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201028/0aea32ec/attachment.htm>