[Webkit-unassigned] [Bug 218264] New: Make RenderingMode a bool enum and remove ShouldAccelerate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218264

            Bug ID: 218264
           Summary: Make RenderingMode a bool enum and remove
                    ShouldAccelerate
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Canvas
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sabouhallawa at apple.com
                CC: dino at apple.com

The following four values are only used in one instance of ImageBuffer::create():

RenderingMode::DisplayListAccelerated,
RenderingMode::DisplayListUnaccelerated,
RenderingMode::RemoteAccelerated,
RenderingMode::RemoteUnaccelerated

Many places in the code convert from RenderingMode to ShouldAccelerate and vice versa. Also one of the WebChromeClient::createImageBuffer() always returns null since it does not override its virtual function in the base class ChromeClient.

So RenderingMode is converted back to be a bool enum as it was before and ShouldAccelerate will be removed. No conversion is needed anymore. And only one instance of ImageBuffer::create() will be handling  creating the remote and display list ImageBuffers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201027/68688ab4/attachment.htm>