[Webkit-unassigned] [Bug 216172] [JSC] Use symbols as identifiers for class fields computed names storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216172

Caitlin Potter (:caitp) <caitp at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caitp at igalia.com

--- Comment #19 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Comment on attachment 412410
  --> https://bugs.webkit.org/attachment.cgi?id=412410
Use symbols as identifiers, v7

View in context: https://bugs.webkit.org/attachment.cgi?id=412410&action=review

overall it looks ok to me

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:4827
> +            setFunctionName = true;

it looks like this is only used by ComputedName, so we can probably get rid of it and just add `&& m_type != DefineFieldNode::Type::ComputedName` to the if condition

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:4868
> +        if (setFunctionName)

and replace this with `if (generator.shouldSetFunctionName(m_assign)`

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201027/c944a29e/attachment-0001.htm>