[Webkit-unassigned] [Bug 217829] [Cairo] REGRESSION(r268176): media/video-orientation-canvas.html is failing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217829

--- Comment #3 from Lauro Moura <lmoura at igalia.com> ---
Checking the (In reply to Philippe Normand from comment #2)
> Setting didUseWidthAsHeight to false in CairoOperations.cpp line 919 makes
> the test pass again.

An initial investigation showed that Cairo::drawNativeImage somehow was invoked differently when the 90deg rotated video is drawn to the canvas in comparison to a 90deg image.

For the image (subject of the original patch), both destination and source rect already arrived with the same orientation (same height and width), so the `ifs` check inside drawNativeImage transposed the destination rect to the expected orientation so drawSurface could scale/pad correctly.

Now with video, the orientation information is there too (The source data is rotated 90deg) but the destination rect arrives already transposed. This causes the same if block to transpose again, leading to drawNativeSurface to scale/pad the video incorrectly.

Next I'll check how the destination rects are provided to drawNativeImage.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201027/237d9f63/attachment.htm>