[Webkit-unassigned] [Bug 217737] Twitter Photo gallery incorrectly rendered after opening another modal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217737

Amy Simmons <asimmons at twitter.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |asimmons at twitter.com

--- Comment #8 from Amy Simmons <asimmons at twitter.com> ---
Hi,

In case this additional info helps. These are some notes I took at the time we added the border radius of 0.01px.

What we know about the bug:

- Only happens in Safari
- Only happens after exiting the Reply or RT with comment tweet actions, does not happen after exiting the Send via DM tweet action
- Only happens on tweets with multiple images, not on single images
- Only happens when pressing the 'X' to dismiss the tweet action, does not happen when pressing the mask to go back
- After some playing around, you can no longer reproduce the issue, and need to close Safari and re-open in order to reproduce it again 

How I got to the borderRadius 0.01px solution:

- I had been working on a series of enhancements to the media viewer, one of which was making it full screen (previously it was not a full screen modal)
- I checked out several of my changes to see at what point the bug was introduced. It was introduced in the very first ticket, where I changed the width and height of the modal to make it full screen and removed the border radius
- Previously, all modals had a border radius. But with the new full screen modal, we no longer needed a border radius. So when I implemented the full screen modal I chose to only add a border radius when the modal size was something other than 'full'. Eg the compose modal would have the border radius, but the full screen media modal would not.
- I don't understand why adding the borderRadius of 0.01px back in fixes the bug, why it was only an issue for the Reply or RT with Comment tweet actions (not the Send via DM tweet action), or why it was only an issue when clicking the X to dismiss, rather than the mask.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201021/997ad01a/attachment-0001.htm>