[Webkit-unassigned] [Bug 218001] New: Remove use of in-makefile grepping of FEATURE_AND_PLATFORM_DEFINES
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 20 16:08:21 PDT 2020
https://bugs.webkit.org/show_bug.cgi?id=218001
Bug ID: 218001
Summary: Remove use of in-makefile grepping of
FEATURE_AND_PLATFORM_DEFINES
Product: WebKit
Version: WebKit Nightly Build
Hardware: Unspecified
OS: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: WebCore Misc.
Assignee: webkit-unassigned at lists.webkit.org
Reporter: sam at webkit.org
To make things simpler, and allow for passing FEATURE_AND_PLATFORM_DEFINES as a file rather than on the command line, we should remove the in-makefile use of grepping FEATURE_AND_PLATFORM_DEFINES.
For the ones conditionalizing adding to ADDITIONAL_BINDING_IDLS, those IDLs should just have the appropriate Conditional=* extended attribute added, then they can be included unconditionally in the makefile.
For the ones conditionalizing adding go USER_AGENT_STYLE_SHEETS, again, there doesn’t seem a real reason to keep that. The sheets are all preprocessed anyway, so we can just move those #ifdefs into the files.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201020/14f1d12b/attachment.htm>
More information about the webkit-unassigned
mailing list