[Webkit-unassigned] [Bug 217819] WebDriver: add support for right variations of virtual keys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217819

--- Comment #11 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 411740
  --> https://bugs.webkit.org/attachment.cgi?id=411740
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411740&action=review

>>> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:1865
>>> +static VirtualKey normalizedVirtualKey(VirtualKey key)
>> 
>> Isn’t the type named Inspector::Protocol::Automation::VirtualKey? What injects VirtualKey into the WebKit namespace? Why can we just write VirtualKey in the argument types but then need to write the whole type out in the function body?
> 
> The enum names are shortened in SimulatedInputDispatcher.h in order to make the members more readable. This file includes that header.
> 
> 
> using KeyboardInteraction = Inspector::Protocol::Automation::KeyboardInteractionType;
> using VirtualKey = Inspector::Protocol::Automation::VirtualKey;
> using VirtualKeySet = HashSet<VirtualKey, WTF::IntHash<VirtualKey>, WTF::StrongEnumHashTraits<VirtualKey>>;
> using MouseButton = Inspector::Protocol::Automation::MouseButton;
> using MouseInteraction = Inspector::Protocol::Automation::MouseInteraction;
> using MouseMoveOrigin = Inspector::Protocol::Automation::MouseMoveOrigin;

I don't understand this change at all. Can you put this funciton in #if ENABLE(WEBDRIVER_ACTIONS_API), KaL?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201020/bdf3749e/attachment.htm>