[Webkit-unassigned] [Bug 217635] Elements in Shadow DOM are wrongly marked as stale by the WebDriver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217635

Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #411275|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #7 from Brian Burg <bburg at apple.com> ---
Comment on attachment 411275
  --> https://bugs.webkit.org/attachment.cgi?id=411275
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411275&action=review

r=me

Please fix typos in the Changelog and I'll set cq+.

> Source/WebDriver/ChangeLog:9
> +        instead of document.contains which doesnt work for elements in Shadow DOM

Nit: 'doesn't'
Nit: ending period.

> Source/WebKit/ChangeLog:9
> +        instead of declaring them as not interactable

Nit: ending period.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201019/ea1e0587/attachment-0001.htm>