[Webkit-unassigned] [Bug 217869] Minor additions to minibrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217869

--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 411719
  --> https://bugs.webkit.org/attachment.cgi?id=411719
new patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411719&action=review

> Tools/MiniBrowser/mac/SettingsController.m:717
>  }
> -
> +- (void)toggleAllowInvalidHTTPSWebsites:(id)sender
> +{
> +    [self _toggleBooleanDefault:AllowInvalidHTTPSWebsitesKey];
> +}
> +- (BOOL)allowInvalidHTTPSWebsites
> +{
> +    return [[NSUserDefaults standardUserDefaults] boolForKey:AllowInvalidHTTPSWebsitesKey];
> +}
>  - (BOOL)nonFastScrollableRegionOverlayVisible

We’re leaving blank lines between the methods here, so I suggest the new code follow suit.

> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:114
> +    SettingsController *settingsController = NSApplication.sharedApplication.browserAppDelegate.settingsController;

Funny that you made this change here, but not in your own new code ;)

> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:796
> +    if ([challenge protectionSpace].serverTrust && settingsController.allowInvalidHTTPSWebsites) {

Could write challenge.protectionSpace.serverTrust.

> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:797
> +        // and if self signed enabled

I don’t understand this comment.

> Tools/MiniBrowser/mac/WK2BrowserWindowController.m:798
> +        NSURLCredential *credential = [[NSURLCredential alloc] initWithTrust:[challenge protectionSpace].serverTrust];

Could write challenge.protectionSpace.serverTrust.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201018/baef1e02/attachment.htm>