[Webkit-unassigned] [Bug 217855] New: Fix -Wdeprecated-copy warnings in WTF and JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217855

            Bug ID: 217855
           Summary: Fix -Wdeprecated-copy warnings in WTF and
                    JavaScriptCore
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Keywords: InRadar
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: darin at apple.com, mark.lam at apple.com

Fix -Wdeprecated-copy warnings in WTF and JavaScriptCore.

1. In JavaScriptCore:

Source/JavaScriptCore/assembler/ARM64Assembler.h:371:14: error: definition of implicit copy constructor for 'LinkRecord' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]
Source/JavaScriptCore/assembler/ARM64Assembler.h:371:14: error: definition of implicit copy constructor for 'LinkRecord' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy]

2. In WTF (via WebKit):

In file included from WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource55-mm.mm:3:
In file included from Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:27:
In file included from Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:41:
WebKitBuild/Release/usr/local/include/wtf/Identified.h:42:5: warning: definition of implicit copy assignment operator for 'IdentifiedBase<unsigned long long, WebKit::PDFPlugin::ByteRangeRequest>' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]
    IdentifiedBase(const IdentifiedBase& other)
    ^
WebKitBuild/Release/usr/local/include/wtf/Identified.h:57:7: note: in implicit copy assignment operator for 'WTF::IdentifiedBase<unsigned long long, WebKit::PDFPlugin::ByteRangeRequest>' first required here
class Identified : public IdentifiedBase<uint64_t, T> {
      ^
In file included from WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource55-mm.mm:3:
In file included from Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:27:
Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h:381:11: note: in implicit copy assignment operator for 'WTF::Identified<WebKit::PDFPlugin::ByteRangeRequest>' first required here
    class ByteRangeRequest : public Identified<ByteRangeRequest> {
          ^
In file included from WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource55-mm.mm:1:
In file included from Source/WebKit/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:27:
In file included from Source/WebKit/WebProcess/Plugins/Netscape/NetscapePlugin.h:31:
In file included from Source/WebKit/WebProcess/Plugins/Plugin.h:30:
In file included from WebKitBuild/Release/WebCore.framework/PrivateHeaders/ScrollTypes.h:28:
In file included from WebKitBuild/Release/WebCore.framework/PrivateHeaders/IntPoint.h:28:
In file included from WebKitBuild/Release/WebCore.framework/PrivateHeaders/IntSize.h:29:
In file included from WebKitBuild/Release/usr/local/include/wtf/JSONValues.h:35:
WebKitBuild/Release/usr/local/include/wtf/HashMap.h:351:32: note: in implicit move assignment operator for 'WebKit::PDFPlugin::ByteRangeRequest' first required here
        result.iterator->value = std::forward<V>(value);
                               ^
WebKitBuild/Release/usr/local/include/wtf/HashMap.h:374:12: note: in instantiation of function template specialization 'WTF::HashMap<unsigned long long, WebKit::PDFPlugin::ByteRangeRequest, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::PDFPlugin::ByteRangeRequest>>::inlineSet<const unsigned long long &, WebKit::PDFPlugin::ByteRangeRequest>' requested here
    return inlineSet(key, std::forward<T>(mapped));
           ^
In file included from WebKitBuild/Release/DerivedSources/WebKit2/unified-sources/UnifiedSource55-mm.mm:3:
Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:966:36: note: in instantiation of function template specialization 'WTF::HashMap<unsigned long long, WebKit::PDFPlugin::ByteRangeRequest, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WebKit::PDFPlugin::ByteRangeRequest>>::set<WebKit::PDFPlugin::ByteRangeRequest>' requested here
    m_outstandingByteRangeRequests.set(identifier, WTFMove(request));
                                   ^

<rdar://problem/67716914>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201016/d6377a82/attachment.htm>