[Webkit-unassigned] [Bug 137297] Allowing eval'ed code to be named in stack traces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137297

--- Comment #9 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 411597
  --> https://bugs.webkit.org/attachment.cgi?id=411597
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411597&action=review

> Source/JavaScriptCore/runtime/StackFrame.cpp:70
> +    String sourceURLDirective = m_codeBlock->ownerExecutable()->source().provider()->sourceURLDirective();

Are we sure that `provider()` exists?

> LayoutTests/inspector/model/remote-object/error-expected.txt:34
> +        "_name": "sourceURL",
> +        "_type": "string",
> +        "_value": "__WebInspectorInternal__"

This slightly concerns me, as it exposes the fact that the evaluation came from Web Inspector.

> LayoutTests/inspector/model/remote-object/error-expected.txt:-117
> -        "_name": "name",
> -        "_type": "string",
> -        "_value": "IndexSizeError"

NOTE: I think this disappeared because the preview only shows five properties

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201016/4310525d/attachment-0001.htm>