[Webkit-unassigned] [Bug 217183] [iOS 14] Hang in -[WKUserDefaults _notifyObserversOfChangeFromValuesForKeys:toValuesForKeys:]

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217183

--- Comment #17 from Per Arne Vollan <pvollan at apple.com> ---
(In reply to Darin Adler from comment #16)
> Comment on attachment 411167 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411167&action=review
> 
> > Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm:95
> > +    if (!isMainThread()) {
> > +        [self findPreferenceChangesAndNotifyForKeys:oldValues toValuesForKeys:newValues];
> > +        return;
> > +    }
> 
> Why do we need this?

This is to avoid extra thread hopping if the method is already being called on a non-main thread.

Thanks for reviewing!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201013/5ae7ad77/attachment.htm>