[Webkit-unassigned] [Bug 217668] Null dereference in PDFPlugin::snapshot()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217668

--- Comment #9 from Julian Gonzalez <julian_a_gonzalez at apple.com> ---
(In reply to Ryosuke Niwa from comment #7)
> Comment on attachment 411267 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411267&action=review
> 
> > LayoutTests/plugins/pdf-plugin-null-onloaddeddata.html:4
> > +/*begincss*/
> 
> This comment is useless. Please remove it.
> 

Will do.

> > LayoutTests/plugins/pdf-plugin-null-onloaddeddata.html:5
> > +:not(glyphRef) { zoom: 61; }
> 
> Do we really need it?
> If we do, I presume we only need it on body or embed so I'd suggest either
> one of:
> embed { zoom: 61; }
> body { zoom: 61; }
> embed, body { zoom: 61; }
> 

We do, unfortunately. I'll try the suggestions.

> > LayoutTests/plugins/pdf-plugin-null-onloaddeddata.html:6
> > +/*endcss*/
> 
> Ditto.

Ditto the ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201013/daed54c2/attachment-0001.htm>