[Webkit-unassigned] [Bug 203292] Accessory bar next/previous buttons do not work on inputs in shadow roots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203292

--- Comment #25 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 411122
  --> https://bugs.webkit.org/attachment.cgi?id=411122
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411122&action=review

It's not great to split these tests into multiple files. Now not all the combinations are tested.
Also, it seems like once accessory-bar-work-on-input-with-tabindex-in-shadow-tree.html becomes complete,
all other test files are sort of redundant.

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-in-shadow-roots.html:130
> +} else {
> +    document.getElementById('console').style.display = 'none';
> +}

Nit: not curly bracket around a single line statement:
https://webkit.org/code-style-guidelines/#braces-one-line

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-in-shadow-tree.html:33
> +    this
> +        .attachShadow({ mode: 'open' })
> +        .innerHTML = '<p><input onfocus="logOnFocus(this)" placeholder="1. input hosted by input-holder"/></p>';

Can we place attachShadow & this in the same line?

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-in-shadow-tree.html:43
> +    this
> +        .attachShadow({ mode: 'open' })

Ditto.

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-in-shadow-tree.html:44
> +        .innerHTML = '<input-holder></input-holder>';

We should add another input before & after this inner shadow host.

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-with-tabindex-in-shadow-tree.html:22
> +    <input id="input-host-with-positive-tabindex" tabindex="0" onfocus="logOnFocus(this)" placeholder="1. Shadow host with a positive tabindex" />

Seems like we're missing setting tabIndex to positive & negative values in the slotted content.

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-with-tabindex-in-shadow-tree.html:45
> +    <slot></slot>
> +    <input id="inside-shadow-host-with-positive-tabindex" tabindex="0" onfocus="logOnFocus(this)" placeholder="2. Focusable element inside a shadow host with a positive tabindex"/>

It seems like we're missing a test case where set a positive & negative tabIndex values inside a shadow tree.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201013/4d781333/attachment.htm>