[Webkit-unassigned] [Bug 217635] Elements in Shadow DOM are wrongly marked as stale by the WebDriver

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217635

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #411160|review?                     |review-
              Flags|                            |

--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 411160
  --> https://bugs.webkit.org/attachment.cgi?id=411160
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411160&action=review

> Source/WebDriver/Session.cpp:2088
> +                    "    var activeElement = doc.activeElement;"

Please use let instead of var like the rest of the function.

> Source/WebDriver/Session.cpp:2090
> +                    "       var shadowRoot = activeElement.shadowRoot;"

This will only work with open shadow roots. That's not right.

> Source/WebDriver/Session.cpp:2098
> +                    "    if (element != activeElement)"

This will do that trick:
element != element.getRootNode().activeElement

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201013/3d080c30/attachment-0001.htm>