[Webkit-unassigned] [Bug 217584] Ignore deployment suffix and identifier when computing major OS version for macOS Big Sur and newer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217584

--- Comment #13 from Darin Adler <darin at apple.com> ---
Comment on attachment 411072
  --> https://bugs.webkit.org/attachment.cgi?id=411072
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411072&action=review

>>> Source/JavaScriptCore/Configurations/Base.xcconfig:106
>>> +TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = 10$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)
>> 
>> I've never seen "a = b = c" in an xcconfig file before. Especially when it's "a = a = c". Is this correct, or a copy/paste error?
> 
> Uh-oh. Copy/paste error. Uploading another patch.

Good catch! It’s right in ANGLE but wrong in the others.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201011/1675c9ea/attachment.htm>