[Webkit-unassigned] [Bug 217590] New: -Wreorder in MediaPlayerPrivateRemote.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217590

            Bug ID: 217590
           Summary: -Wreorder in MediaPlayerPrivateRemote.cpp
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at gnome.org
                CC: stephan.szabo at sony.com

-Wreorder indicates the constructor's initializer list is misleading:

[2116/2435] Building CXX object Source/WebKit/CMakeFiles/...ces/WebKit/unified-sources/UnifiedSource-54928a2b-2.cpp.o
In file included from ../../Source/WebKit/WebProcess/GPU/media/AudioTrackPrivateRemote.cpp:32,
                 from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-2.cpp:7:
../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h: In constructor ‘WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote(WebCore::MediaPlayer*, WebCore::MediaPlayerEnums::MediaEngineIdentifier, WebCore::MediaPlayerIdentifier, WebKit::RemoteMediaPlayerManager&)’:
../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:362:27: warning: ‘WebKit::MediaPlayerPrivateRemote::m_player’ will be initialized after [-Wreorder]
  362 |     WebCore::MediaPlayer* m_player { nullptr };
      |                           ^~~~~~~~
../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.h:159:23: warning:   ‘WTF::Ref<const WTF::Logger, WTF::DumbPtrTraits<const WTF::Logger> > WebKit::MediaPlayerPrivateRemote::m_logger’ [-Wreorder]
  159 |     Ref<const Logger> m_logger;
      |                       ^~~~~~~~
In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-2.cpp:8:
../../Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:94:1: warning:   when initialized here [-Wreorder]
   94 | MediaPlayerPrivateRemote::MediaPlayerPrivateRemote(MediaPlayer* player, MediaPlayerEnums::MediaEngineIdentifier engineIdentifier, MediaPlayerIdentifier playerIdentifier, RemoteMediaPlayerManager& manager)
      | ^~~~~~~~~~~~~~~~~~~~~~~~

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201011/cc0b7307/attachment.htm>