[Webkit-unassigned] [Bug 217584] Ignore deployment suffix and identifier when computing major OS version for macOS Big Sur and newer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217584

--- Comment #10 from Luming Yin <luming_yin at apple.com> ---
(In reply to Darin Adler from comment #8)
> Comment on attachment 411070 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411070&action=review
> 
> > Source/JavaScriptCore/Configurations/Base.xcconfig:106
> > +TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = $(MACOSX_DEPLOYMENT_TARGET:base)$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)
> 
> I think this should use "10" instead of "$(MACOSX_DEPLOYMENT_TARGET:base)"

Good idea. Patch updated to use "10" instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201011/029a89cc/attachment.htm>