[Webkit-unassigned] [Bug 217584] Ignore deployment suffix and identifier when computing major OS version for macOS Big Sur and newer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217584

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #411070|review?                     |review+
              Flags|                            |

--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 411070
  --> https://bugs.webkit.org/attachment.cgi?id=411070
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411070&action=review

> Source/JavaScriptCore/Configurations/Base.xcconfig:106
> +TARGET_MACOS_LEGACY_VERSION_IDENTIFIER_10 = $(MACOSX_DEPLOYMENT_TARGET:base)$(MACOSX_DEPLOYMENT_TARGET:suffix:identifier)

I think this should use "10" instead of "$(MACOSX_DEPLOYMENT_TARGET:base)"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201011/ce132846/attachment.htm>