[Webkit-unassigned] [Bug 203292] Accessory bar next/previous buttons do not work on inputs in shadow roots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203292

--- Comment #20 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 410953
  --> https://bugs.webkit.org/attachment.cgi?id=410953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410953&action=review

> Source/WebCore/ChangeLog:9
> +        Tests: platform/ios/ios/fast/shadow-dom/accessory-bar-work-on-input-in-shadow-roots.html
> +               platform/ios/ios/fast/shadow-dom/accessory-bar-work-on-input-in-shadow-tree.html

This isn't right. We need to have this test under fast/shadow-dom/ios as you did in your original patch.

platform directories are supposed to only contain -expected.txt files going forward.

> LayoutTests/platform/ios/ios/fast/shadow-dom/accessory-bar-work-on-input-in-shadow-roots.html:14
> +        <input type="text" onfocus="logOnFocus(this)" placeholder="0. Shadow DOM Input 0">

Just do: Array.from(document.querySelectorAll('input')).forEach((input) => input.addEventListener(logOnFocus)).

We also need to test input elements inside a shadow tree, input elements hosts not assigned to any slot,
as well as non-input elements with negative, positive, and 0 tabIndex.

This is why I was suggesting earlier to model it over other existing tabindex tests.

> LayoutTests/platform/ios/ios/fast/shadow-dom/accessory-bar-work-on-input-in-shadow-roots.html:59
> +<pre style="display: none" id="console-for-manually"></pre>

It's okay for this element to exist even inside WebKitTestRunner. Just forget about display: none.
"manually" is an adverb, we need a noun there instead. We usually call this just "log" so: id="log".

> LayoutTests/platform/ios/ios/fast/shadow-dom/accessory-bar-work-on-input-in-shadow-roots.html:130
> +    consoleForManually.style.display = '';

consoleForManually.style.display = null would be better.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201009/22cac059/attachment-0001.htm>