[Webkit-unassigned] [Bug 203292] Accessory bar next/previous buttons do not work on inputs in shadow roots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=203292

--- Comment #16 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 410867
  --> https://bugs.webkit.org/attachment.cgi?id=410867
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410867&action=review

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-in-shadow-roots.html:61
> +    this
> +        .attachShadow({ mode: 'open' })
> +        .innerHTML = '<p><slot></slot></p>';  

Can we just fit this in a single line?

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-in-shadow-roots.html:72
> +    this
> +        .attachShadow({ mode: 'closed' })
> +        .innerHTML = '<p><slot></slot></p>';  

Ditto.

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-in-shadow-roots.html:78
> +function moveToNextElement() {
> +    return new Promise((resolve) => {

Hm... can we add this function to UIHelper in ui-helper.js?
Maybe call it moveToNextByKeyboardAccessoryBar.

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-in-shadow-roots.html:86
> +function moveToPrevElement() {

Ditto.

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-in-shadow-roots.html:96
> +if (window.testRunner) {
> +    description('Test that Accessory bar next/previous buttons work on inputs in shadow roots');

Please add an instruction on how to test this manually in a browser.

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-in-shadow-roots.html:98
> +    const runTest = async () => {

Can we define this outside if?

> LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-in-shadow-roots.html:112
> +                shouldBe(() => document.activeElement.getAttribute('placeholder'), () => element.getAttribute('placeholder'));

shouldBe doesn't take functions. They take strings to be eval'ed.

Can we mirror tests like negative-tabindex-on-shadow-host and just log the element which got focus?
This will allow easier manual testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201008/559a4fe4/attachment.htm>