[Webkit-unassigned] [Bug 217427] [LFC][Integration] Add line iterator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217427

zalan <zalan at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #410747|review?                     |review+
              Flags|                            |

--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 410747
  --> https://bugs.webkit.org/attachment.cgi?id=410747
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410747&action=review

> Source/WebCore/layout/integration/LayoutIntegrationRunIterator.h:65
> +    float logicalLeft() const { return isHorizontal() ? rect().x() : rect().y(); }
> +    float logicalRight() const { return isHorizontal() ? rect().maxX() : rect().maxY(); }
> +    float logicalWidth() const { return isHorizontal() ? rect().width() : rect().height(); }
> +    float logicalHeight() const { return isHorizontal() ? rect().height() : rect().width(); }

Assuming that the display items are all flipped from logical to physical during the layout -> display transition, is this the case when the caller really expects logical coordinates here and we need to flip them back from physical to logical (curious about the use case)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201007/e087ec60/attachment-0001.htm>