[Webkit-unassigned] [Bug 197158] Using CSS wide keywords as a fallback for variable substitution works inconsistently.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=197158

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #410678|review?                     |review+
              Flags|                            |

--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 410678
  --> https://bugs.webkit.org/attachment.cgi?id=410678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410678&action=review

>> Source/WebCore/css/parser/CSSPropertyParser.cpp:296
>> +    if (value)
> 
> Can value ever be null here?

It can’t and this if statement can be removed.

> Source/WebCore/css/parser/CSSPropertyParser.cpp:304
> +    if (RefPtr<CSSValue> value = maybeConsumeCSSWideKeyword(parser.m_range))

auto

> Source/WebCore/css/parser/CSSPropertyParser.cpp:369
> +    RefPtr<CSSValue> value = maybeConsumeCSSWideKeyword(rangeCopy);

auto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201007/fd952cab/attachment-0001.htm>