[Webkit-unassigned] [Bug 217072] Add WKContentWorld declarations required by _WKUserStyleSheet

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=217072

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thorton at apple.com
 Attachment #409940|review+                     |review-
              Flags|                            |

--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 409940
  --> https://bugs.webkit.org/attachment.cgi?id=409940
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409940&action=review

> Source/WebKit/ChangeLog:12
> +        _WKUserStyleSheet uses WKContentWorld, but doesn't import it specifically. In the unified
> +        build, _WKUserContentWorld.mm (which transitively includes the header that defines
> +        WKContentWorld) is listed two lines above _WKUserStyleSheet.mm, which often means that this
> +        issue gets hidden if the split occurs such that they end up in the same compilation unit.
> +        This change should allow the build to work regardless of whether the files end up together.
> +
> +        Add WKContentWorld declarations required by _WKUserStyleSheet
> +        https://bugs.webkit.org/show_bug.cgi?id=217072
> +
> +        Reviewed by NOBODY (OOPS!).

Your changelog is not quite in the right order! Look at other examples; it goes

Title
Bug

Reviewed By

Description

File List

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201006/27ac793b/attachment.htm>