[Webkit-unassigned] [Bug 198512] Presence of CSS variable causes a background url() to get resolved with a different base

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=198512

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #410448|review?                     |review+
              Flags|                            |

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 410448
  --> https://bugs.webkit.org/attachment.cgi?id=410448
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410448&action=review

> Source/WebCore/css/CSSPendingSubstitutionValue.h:40
> +    static Ref<CSSPendingSubstitutionValue> create(CSSPropertyID shorthandPropertyId, Ref<CSSVariableReferenceValue>&& shorthandValue, const URL baseURL)

"const URL" is not the type we want for this argument. Could use "const URL&" or "URL".

> Source/WebCore/css/CSSPendingSubstitutionValue.h:47
> +    const URL baseURL() const { return m_baseURL; }

Same here with return value. It can be URL or const URL&, but const URL is not right.

> Source/WebCore/css/CSSPendingSubstitutionValue.h:64
> +    const URL m_baseURL;

Here, the type "const URL" is fine, good, appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201004/a110b54a/attachment.htm>