[Webkit-unassigned] [Bug 219192] [WASM-References] Add support for active mods in element section

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219192

--- Comment #10 from Dmitry <dbezhetskov at igalia.com> ---
Comment on attachment 414886
  --> https://bugs.webkit.org/attachment.cgi?id=414886
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414886&action=review

>> Source/JavaScriptCore/ChangeLog:7
>> +        Adjust wasm parser to parse new form of element section.
> 
> Nit: We usually put a new line here.

Fixed.

>> Source/JavaScriptCore/ChangeLog:10
>> +        Add support for vec(exp) in element section:
> 
> can you explain what it used t be and how this is different?

Removed implementation details from high-level description.

>> Source/JavaScriptCore/wasm/WasmFormat.h:250
>> +    Vector<Optional<uint32_t>> functionIndices;
> 
> Since this is long lived, and could be very large (many modules I've seen have 10k+ functions), we should probably use a sentinel value that's not realistic like UINT_MAX. Right now I think this is doubling the memory of this vector.

Fixed this and all other issues. Now design of this is just one-one copy from SpiderMonkey :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201201/34f0dd41/attachment.htm>