[Webkit-unassigned] [Bug 216601] getComputedStyle rounds lineHeight to nearest pixel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216601

--- Comment #7 from Tyler Wilcock <twilco.o at protonmail.com> ---
(In reply to Antti Koivisto from comment #6)
> Comment on attachment 414914 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=414914&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-computed-expected.txt:10
> > -FAIL Property font value 'normal normal xx-large/1.2 cursive' assert_equals: expected "32px / 38px cursive" but got "normal normal normal normal 32px/38px cursive"
> > +FAIL Property font value 'normal normal xx-large/1.2 cursive' assert_equals: expected "32px / 38.400001525878906px cursive" but got "normal normal normal normal 32px/38.400001525878906px cursive"
> 
> We appear to be failing these WPT tests harder than before?

How so?  With this patch, both the expectations and results for line-height values have been updated to be fractional.  Both Gecko and Chromium also serialize these fractionally for this test.  Maybe I'm missing your point, though -- can you elaborate?

wpt.fyi: https://wpt.fyi/results/css/css-fonts/parsing/font-computed.html?label=master&label=experimental&aligned&q=css%2Fcss-fonts

Test source: https://github.com/web-platform-tests/wpt/blob/master/css/css-fonts/parsing/font-computed.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201127/f6e62132/attachment-0001.htm>