[Webkit-unassigned] [Bug 219177] zero boundingRect pointer in Font::platformBoundsForGlyph() to CTFontGetBoundingRectsForGlyphs()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219177

--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
(In reply to Darin Adler from comment #2)
> Comment on attachment 414618 [details]
> Patch
> 
> Good to have the code match what the change log says. And it was my comment
> that led to this change.

Yeah, we should mention this in the change log.

> But why does this need to be a zero rect rather than uninitialized? And why
> can’t we pass nullptr instead?

So the person who maintains this function told us that passing nullptr will result in heap memory allocation so it's slightly more efficient to pass in a rect.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201120/739b7db2/attachment.htm>