[Webkit-unassigned] [Bug 219092] check-webkit-style should require spaces around the equal sign for Objective-C @synthesize

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 19 09:02:34 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=219092

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #414458|review?, commit-queue-      |review+
              Flags|                            |

--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 414458
  --> https://bugs.webkit.org/attachment.cgi?id=414458
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414458&action=review

> Tools/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Ideally, there should be a sentence or two below the "Reviewed by" line describing the change. Maybe something like along the lines of:

```
Teach the Objective-C style checker to prefer `@synthesize a = b` over `@synthesize a=b`. As a followup,
<webkit.org/b/219094> will enforce this style rule in existing @synthesize statements in WebKit.
```

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201119/557ca4d7/attachment-0001.htm>


More information about the webkit-unassigned mailing list