[Webkit-unassigned] [Bug 219034] CodeBlock m_shouldAlwaysBeInlined in JIT::compileWithoutLinking should be set directly.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219034

--- Comment #4 from xc.o.c.1180 at gmail.com <xc.o.c.1180 at gmail.com> ---
Comment on attachment 414573
  --> https://bugs.webkit.org/attachment.cgi?id=414573
Patch

>Subversion Revision: 270020
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 368551eaad5e5da24d5379302ce8fe93c84db7a5..320f325f77418f95dc498d7a1582151b4fa6e7e2 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2020-11-19  xc.o.c.1180 at gmail.com
>+
>+        CodeBlock m_shouldAlwaysBeInlined in JIT::compileWithoutLinking should be set directly.
>+        https://bugs.webkit.org/show_bug.cgi?id=219034
>+
>+        Reviewed by Yusuke Suzuki.
>+
>+	It does not depend on JS execution, this saves a few JIT codes.
>+
>+        * jit/JIT.cpp:
>+        (JSC::JIT::compileWithoutLinking):
>+
> 2020-11-18  Dmitry Bezhetskov  <dbezhetskov at igalia.com>
> 
>         [WASM-References] Remove subtyping rule for externref and funcref
>diff --git a/Source/JavaScriptCore/jit/JIT.cpp b/Source/JavaScriptCore/jit/JIT.cpp
>index ce87c8764775fafb0c879f59e9f94a3908f86cc3..f33911356ac0b8af0366a5adeaa8fddcb34c5cf2 100644
>--- a/Source/JavaScriptCore/jit/JIT.cpp
>+++ b/Source/JavaScriptCore/jit/JIT.cpp
>@@ -786,7 +786,7 @@ void JIT::compileWithoutLinking(JITCompilationEffort effort)
>     bool requiresArityFixup = m_codeBlock->m_numParameters != 1;
>     if (m_codeBlock->codeType() == FunctionCode && requiresArityFixup) {
>         m_arityCheck = label();
>-        store8(TrustedImm32(0), &m_codeBlock->m_shouldAlwaysBeInlined);
>+        m_codeBlock->m_shouldAlwaysBeInlined = false;
>         emitFunctionPrologue();
>         emitPutToCallFrameHeader(m_codeBlock, CallFrameSlot::codeBlock);
>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201119/a3f24ed6/attachment-0001.htm>