[Webkit-unassigned] [Bug 219081] [GTK] MiniBrowser: add an option to quit the browser after loading finishes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219081

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clopez at igalia.com
 Attachment #414444|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 414444
  --> https://bugs.webkit.org/attachment.cgi?id=414444
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414444&action=review

> Tools/MiniBrowser/gtk/main.c:594
> +static void exitAfterWebProcessCrashed(WebKitWebView *webView, WebKitWebProcessTerminationReason reason, GApplication *application)
> +{
> +    if (reason == WEBKIT_WEB_PROCESS_CRASHED)
> +        exitAfterWebViewLoadFinishesCallback(webView, WEBKIT_LOAD_FINISHED, application);

In this case I think it will be useful to print an error message saying that the webprocess has crashed.
Otherwise it can be confusing, and the user can't easily tell if the minibrowser is exiting because the load has finished correctly or because of a crash from the webprocess.
Also setting a non-zero exit code in this case can be also useful for tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201119/dfc23233/attachment.htm>