[Webkit-unassigned] [Bug 214297] [JSC] Add support for static private class fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214297

--- Comment #9 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 414562
  --> https://bugs.webkit.org/attachment.cgi?id=414562
Add support for static private fields, v3

View in context: https://bugs.webkit.org/attachment.cgi?id=414562&action=review

> Source/JavaScriptCore/tools/JSDollarVM.cpp:3385
> +    Symbol* symbol = asSymbol(callFrame->argument(0));

"asSymbol" don't work if `value.asCell()->isSymbol()` is false. This is going to break whenever we call `isPrivateSymbol(x)` and x is not a Symbol. We should just call  `asSymbol` when we are sure that JSValue is a Symbol. I think what you meant to use here is:

```
...
if (!callFrame->argument(0).isSymbol())
...
```

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201119/3e8744cc/attachment.htm>