[Webkit-unassigned] [Bug 219032] Build webkit using VS2017 x86 failed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219032

--- Comment #3 from jasonshan <shanjun at homemart.com.cn> ---
AppleWin port. I've read the issues you linked, but didn't solve my problem.

I found the error comes from this file: $(WEBKIT_OUTPUTDIR)\DerivedSources\JavaScriptCore\LLIntDesiredOffsets.h, which is generated by Project: JavaScriptCore\LLIntOffsetsExtractor using command as below:
D:\Webkit\cygwin\bin\ruby.exe D:/Webkit/cygwin/home/administrator/webkit/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb -ID:/Webkit/cygwin/home/administrator/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/ D:/Webkit/cygwin/home/administrator/webkit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm D:/Webkit/cygwin/home/administrator/webkit/WebKitBuild/Release/Win32/LLIntSettingsExtractor.exe D:/Webkit/cygwin/home/administrator/webkit/WebKitBuild/Release/DerivedSources/JavaScriptCore/LLIntDesiredOffsets.h "X86_WIN, C_LOOP_WIN"

and the contents of LLIntDesiredOffsets.h
// OffsetExtractor input hash: 828b554162b8786893aaf1c6d2f9b09c13520e38 ef8f58ff01391559db80dc799bf58d6a4f147ecb 21104db74e849a45cb3d052c15051aa4ce0b6876
#if !OFFLINE_ASM_X86 && OFFLINE_ASM_X86_WIN && !OFFLINE_ASM_X86_64 && !OFFLINE_ASM_X86_64_WIN && !OFFLINE_ASM_ARMv7 && !OFFLINE_ASM_ARM64 && !OFFLINE_ASM_ARM64E && !OFFLINE_ASM_MIPS && !OFFLINE_ASM_C_LOOP && !OFFLINE_ASM_C_LOOP_WIN && !OFFLINE_ASM_ARMv7k && !OFFLINE_ASM_ARMv7s && !OFFLINE_ASM_JSVALUE64 && !OFFLINE_ASM_BIGINT32 && !OFFLINE_ASM_GIGACAGE_ENABLED && !OFFLINE_ASM_ASSERT_ENABLED && !OFFLINE_ASM_TRACING && !OFFLINE_ASM_ADDRESS64 && !OFFLINE_ASM_WEBASSEMBLY && !OFFLINE_ASM_HAVE_FAST_TLS
#error "Invalid configuration. Error at: D:/Webkit/cygwin/home/administrator/webkit/Source/JavaScriptCore/llint/LowLevelInterpreter.asm:305"
#endif

I have reviewed the LowLevelInterpreter.asm
if JSVALUE64          //Line 269
.........
else                  //Line 293
    const PC = t4 # When changing this, make sure LLIntPC is up to date in LLIntPCRanges.h
    if C_LOOP or C_LOOP_WIN
        const PB = csr0
        const metadataTable = csr3
    elsif ARMv7
        const metadataTable = csr0
        const PB = csr1
    elsif MIPS
        const metadataTable = csr0
        const PB = csr1
    else
        error        //Line 305
    end
end
since the platform is x86, JSVALUE64 is not defined, in else part, C_LOOP is not defined either, so this generates that error!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201118/2e19e946/attachment.htm>