[Webkit-unassigned] [Bug 214297] [JSC] Add support for static private class fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=214297

Caio Lima <ticaiolima at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ticaiolima at gmail.com

--- Comment #6 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 414430
  --> https://bugs.webkit.org/attachment.cgi?id=414430
Add support for static private fields, v2

View in context: https://bugs.webkit.org/attachment.cgi?id=414430&action=review

> JSTests/stress/class-fields-static-private-harmony.js:344
> +*/

I think it's fine to remove it or maybe include a helper function to check `SymbolIsPrivate`.

> JSTests/stress/class-fields-static-private-harmony.js:390
> +}

Could we include a test that checks if we throw if we try to redefine a private field as static and vice versa?

I also miss a test that verifies if instance of a class can't access static fields. Do you mind adding them if they are missing?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201118/a265f87f/attachment-0001.htm>