[Webkit-unassigned] [Bug 219033] New: StringBuilder append(const String& string) has a few redundant checks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 17 07:27:42 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=219033

            Bug ID: 219033
           Summary: StringBuilder append(const String& string) has a few
                    redundant checks
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: xc.o.c.1180 at gmail.com

Created attachment 414337

  --> https://bugs.webkit.org/attachment.cgi?id=414337&action=review

Proposed patch.

After 'if (!string.length())', string's StringImpl can not be null, a few null checks can be skipped by using StringImpl reference.

Please see patch for details.


Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201117/4601866f/attachment.htm>


More information about the webkit-unassigned mailing list