[Webkit-unassigned] [Bug 194095] [JSC] Add support for static public class fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194095

--- Comment #16 from Xan Lopez <xan.lopez at gmail.com> ---
ACK to everything, save for one comment:

(In reply to Yusuke Suzuki from comment #15)

> we do not use comma typically here.
> 
> > Source/JavaScriptCore/parser/Parser.cpp:3080
> > +    bool isStaticField = false;
> 
> Why is it defined outside of for loop? What happens if the first field is
> static and next field is not static (I think in that case, isStaticField
> boolean becomes wrong).
> Can you add a test about this case?

This method will only parse either a vector of static fields or a vector of instance fields, never a mix. So the case you mention cannot happen (there's all sorts of tests with fields in every possible order and combinations). I have added a comment and added the boolean inside the loop, so this is more clear already within the method itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201117/e7807401/attachment-0001.htm>