[Webkit-unassigned] [Bug 218494] Release assertion failure in Optional<WebCore::SimpleRange>::operator* via CompositeEditCommand::moveParagraphs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218494

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #414211|review?                     |review+
              Flags|                            |

--- Comment #22 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 414211
  --> https://bugs.webkit.org/attachment.cgi?id=414211
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=414211&action=review

> Source/WebCore/editing/CompositeEditCommand.cpp:1403
> +    ASSERT(startOfParagraphToMove == endOfParagraphToMove || !endOfParagraphToMove.isNull());

This is harder to parse than (startOfParagraphToMove.isNull() && endOfParagraphToMove.isNull()) || endOfParagraphToMove.isNull()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201117/16b4b344/attachment.htm>