[Webkit-unassigned] [Bug 218972] New: Use downcast instead of static_cast for casting GraphicsContextGL -> GraphicsContextGLOpenGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=218972

            Bug ID: 218972
           Summary: Use downcast instead of static_cast for casting
                    GraphicsContextGL -> GraphicsContextGLOpenGL
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebGL
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: kkinnunen at apple.com
                CC: dino at apple.com
        Depends on: 218333

Use downcast instead of static_cast for casting GraphicsContextGL to GraphicsContextGLOpenGL

This is to be done only if removing !USE(ANGLE) from WebGL implementation is not possible.

https://bugs.webkit.org/show_bug.cgi?id=218333#c9

Simon Fraser (smfr) 2020-11-13 10:38:15 PST
>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1790
>> +    static_cast<GraphicsContextGLOpenGL*>(m_context.get())->compressedTexImage2D(target, level, internalformat, width, height,

>I think you should add SPECIALIZE_TYPE_TRAITS macros and use downcast<> for all these casts.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=218333
[Bug 218333] Final refactor for WebGL implementation to use only GraphicsContextGL
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201116/532e1a5a/attachment.htm>