[Webkit-unassigned] [Bug 194095] [JSC] Add support for static public class fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=194095

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com

--- Comment #13 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 414161
  --> https://bugs.webkit.org/attachment.cgi?id=414161
Add support for static public fields, v8

View in context: https://bugs.webkit.org/attachment.cgi?id=414161&action=review

I'll comment about some quick things. I'll review it tomorrow or Monday.
Can you put `r?` when requesting a review?

> JSTests/ChangeLog:1
> +2020-06-05  Xan López  <xan at igalia.com>

Let's update the date.

> JSTests/stress/class-fields-harmony.js:34
> +load("./harmony-support.js");

Let's put JSTests/stress/resources/harmony-support.js under resources. Otherwise, harmony-support.js is executed as one test.

> JSTests/stress/class-fields-static-harmony.js:1
> +//@ requireOptions("--usePublicClassFields=1")

Use 'usePublicStaticClassFields'

> JSTests/stress/class-fields-static-harmony.js:36
> +load("./harmony-support.js");

Ditto.

> Source/JavaScriptCore/ChangeLog:1
> +2020-06-05  Xan López  <xan at igalia.com>

Let's update the date.

> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:186
>  

Hmm, I cannot expand the diff in this file.
Can you rebase the patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201115/094c35ae/attachment-0001.htm>