[Webkit-unassigned] [Bug 218607] [GTK] [REGRESSSION(r269390) Several editing/ tests are flaky

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 9 20:32:19 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=218607

Carlos Alberto Lopez Perez <clopez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clopez at igalia.com,
                   |                            |thorton at apple.com
           See Also|                            |https://bugs.webkit.org/sho
                   |                            |w_bug.cgi?id=218569

--- Comment #4 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
I confirm that r268390 caused this regression. Tested locally and I can reproduce the issue with r268390 but not before it

To reproduce the issue simply run the tests inside editing/selection and you will see this:

$ Tools/Scripts/run-webkit-tests --debug-rwt-logging --release --gtk editing/selection

Unexpected flakiness: text-only failures (18)
  editing/selection/extend-after-mouse-selection.html [ Failure Pass ]
  editing/selection/extend-selection-backward-at-beginning-of-line-by-sentence-granularity.html [ Failure Pass ]
  editing/selection/extend-selection-backward-at-beginning-of-line-by-word-granularity.html [ Failure Pass ]
  editing/selection/focus-contenteditable-iframe.html [ Failure Pass ]
  editing/selection/getRangeAt.html [ Failure Pass ]
  editing/selection/move-by-word-visually-across-object-element-1.html [ Failure Pass ]
  editing/selection/move-by-word-visually-across-object-element-2.html [ Failure Pass ]
  editing/selection/move-by-word-visually-across-object-element-3.html [ Failure Pass ]
  editing/selection/select-all-user-select-none.html [ Failure Pass ]
  editing/selection/select-out-of-floated-non-editable-02.html [ Failure Pass ]
  editing/selection/select-out-of-floated-non-editable-07.html [ Failure Pass ]
  editing/selection/select-out-of-floated-non-editable-10.html [ Failure Pass ]
  editing/selection/shift-click-includes-existing-selection.html [ Failure Pass ]
  editing/selection/shift-click.html [ Failure Pass ]
  editing/selection/toString-1.html [ Failure Pass ]
  editing/selection/user-select-all-selection.html [ Failure Pass ]
  editing/selection/user-select-all-with-shift.html [ Failure Pass ]
  editing/selection/user-select-all-with-single-click.html [ Failure Pass ]


You can check the text diffs they give here: https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r269612%20(16890)/results.html


Some observations:

 * Those failed tests failed on the first run, but when they were retried by WTR on the second run they all passed.
 * And if you run the tests one by one, they always pass.
 * Also if you run those tests with several workers (by passing the flags "--child-process=32 -f") then the failures don't happen or happen less (depending on the number of workers you spawn)
 * And finally you can see that if you run those tests by restarting WTR after each test (by passing the flag --run-singly) then the failures also don't happen.

So an hypothesis is that after r268390 one or more tests inside the folder editing/selection is leaving WTR in a inconsistent state that then causes failures on the rest of tests later executed in that WTR process.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201110/7cfa1c23/attachment-0001.htm>


More information about the webkit-unassigned mailing list