[Webkit-unassigned] [Bug 218720] Rename ImageBuffer::flushDisplayList to ImageBuffer::renderDisplayList

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 9 12:09:24 PST 2020


https://bugs.webkit.org/show_bug.cgi?id=218720

--- Comment #1 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
(In reply to Wenson Hsieh from comment #0)
> ImageBuffer's `flushDisplayList` method is currently only responsible for
> replaying the given display list into the image buffer's drawing context,
> and doesn't actually guarantee a context flush. A name like
> `renderDisplayList` seems more fitting.

I think this statement is a little inaccurate. The "flushDisplayList" is responsible for replaying the given display list into the image buffer's "backend context".

Using the "drawing context" is a little vague here because DisplayList::DrawingContext refers to the class that wraps the DisplayList::Recorder.

Regarding the new name "renderDisplayList", I am not sure why it is better than flushDisplayList() especially when we deal with cross process operation and where WebP does not really renders the display list to the backend context.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201109/2168a060/attachment.htm>


More information about the webkit-unassigned mailing list