[Webkit-unassigned] [Bug 216172] [JSC] Use symbols as identifiers for class fields computed names storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=216172

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com

--- Comment #26 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 413571
  --> https://bugs.webkit.org/attachment.cgi?id=413571
Use symbols as identifiers, v9

View in context: https://bugs.webkit.org/attachment.cgi?id=413571&action=review

> Source/WTF/wtf/text/SymbolRegistry.cpp:56
> +    CreateSymbol m_createSymbol;
> +
> +    if (m_symbolType == Type::PrivateSymbol)
> +        m_createSymbol = &RegisteredSymbolImpl::createPrivate;
> +    else
> +        m_createSymbol = &RegisteredSymbolImpl::create;
> +
> +    auto symbol = m_createSymbol(*rep.impl(), *this);

Let's just switch 

if (m_symbolType == Type::PrivateSymbol)
    symbol = RegisteredSymbolImpl::createPrivate(...);
else
    symbol = RegisteredSymbolImpl::create(...);

We don't need to make this a indirect call, and it is slower.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20201109/793cd84a/attachment.htm>